Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public draft feature #725

Merged
merged 7 commits into from Aug 7, 2023
Merged

Add public draft feature #725

merged 7 commits into from Aug 7, 2023

Conversation

NiseVoid
Copy link
Contributor

@NiseVoid NiseVoid commented Aug 4, 2023

An implementation of the draft feature, as described in #623 (comment)

Since the built-in draft feature acts as if pages don't exist at all, this uses a public_draft field under [extra]

@cart
Copy link
Member

cart commented Aug 4, 2023

I think we'll want to sort out this bit from the comment before committing to this workflow:
image

Being able to discover + navigate to draft pages (especially during development) is important for dev workflows.

@cart
Copy link
Member

cart commented Aug 4, 2023

Doing it statically is fine (and makes this comparable to draft flags for dev workflows), but I think being able to do it dynamically both locally and for deployed sites would be best (ex: via url flags and/or a toggle-able cookie)

@NiseVoid NiseVoid marked this pull request as ready for review August 7, 2023 09:25
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Made a few tweaks / resolved my comments

templates/docs-section.html Outdated Show resolved Hide resolved
templates/macros/public_draft.html Outdated Show resolved Hide resolved
@cart cart changed the title Add public draft feature and improve page link Add public draft feature Aug 7, 2023
@cart cart added this pull request to the merge queue Aug 7, 2023
Merged via the queue into bevyengine:main with commit a6f7c4d Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants