Skip to content

Commit

Permalink
Revert "Add cart's fork of ecs_bench_suite (#4225)" (#4252)
Browse files Browse the repository at this point in the history
This reverts commit 08ef2f0.

# Objective

- #4225 was merged without considering the licensing considerations.
- It merges in code taken from https://github.com/cart/ecs_bench_suite/tree/bevy-benches/src/bevy.
- We can safely assume that we do have a license to cart's contributions. However, these build upon cart/ecs_bench_suite@377e96e, for which we have no license. 
- This has been verified by looking in the Cargo.toml, the root folder and the readme, none of which mention a license. Additionally, the string "license" [doesn't appear](https://github.com/rust-gamedev/ecs_bench_suite/search?q=license) in the repository.
- This means the code is all rights reserved.
- (The author of these commits also hasn't commented in #2373, though even if they had, it would be legally *dubious* to rely on that to license any code they ever wrote)
- (Note that the latest commit on the head at https://github.com/rust-gamedev/ecs_bench_suite hasn't had a license added either.)
- We are currently incorrectly claiming to be able to give an MIT/Apache 2.0 license to this code.

## Solution

- Revert it
  • Loading branch information
DJMcNab committed Mar 19, 2022
1 parent 08ef2f0 commit 95d3f32
Show file tree
Hide file tree
Showing 22 changed files with 0 additions and 996 deletions.
6 changes: 0 additions & 6 deletions benches/Cargo.toml
Expand Up @@ -7,16 +7,10 @@ publish = false
license = "MIT OR Apache-2.0"

[dev-dependencies]
glam = "0.20"
criterion = "0.3"
bevy_ecs = { path = "../crates/bevy_ecs" }
bevy_tasks = { path = "../crates/bevy_tasks" }

[[bench]]
name = "ecs_bench_suite"
path = "benches/bevy_ecs/ecs_bench_suite/mod.rs"
harness = false

[[bench]]
name = "system_stage"
path = "benches/bevy_ecs/stages.rs"
Expand Down
30 changes: 0 additions & 30 deletions benches/benches/bevy_ecs/ecs_bench_suite/add_remove.rs

This file was deleted.

This file was deleted.

54 changes: 0 additions & 54 deletions benches/benches/bevy_ecs/ecs_bench_suite/add_remove_big_table.rs

This file was deleted.

31 changes: 0 additions & 31 deletions benches/benches/bevy_ecs/ecs_bench_suite/add_remove_sparse_set.rs

This file was deleted.

30 changes: 0 additions & 30 deletions benches/benches/bevy_ecs/ecs_bench_suite/add_remove_table.rs

This file was deleted.

35 changes: 0 additions & 35 deletions benches/benches/bevy_ecs/ecs_bench_suite/frag_iter.rs

This file was deleted.

35 changes: 0 additions & 35 deletions benches/benches/bevy_ecs/ecs_bench_suite/frag_iter_foreach.rs

This file was deleted.

23 changes: 0 additions & 23 deletions benches/benches/bevy_ecs/ecs_bench_suite/get_component.rs

This file was deleted.

31 changes: 0 additions & 31 deletions benches/benches/bevy_ecs/ecs_bench_suite/get_component_system.rs

This file was deleted.

0 comments on commit 95d3f32

Please sign in to comment.