Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO and Async Compute task spans #12467

Open
james7132 opened this issue Mar 14, 2024 · 0 comments
Open

IO and Async Compute task spans #12467

james7132 opened this issue Mar 14, 2024 · 0 comments
Labels
A-Tasks Tools for parallel and async work C-Enhancement A new feature C-Performance A change motivated by improving speed, memory usage or compile times

Comments

@james7132
Copy link
Member

What problem does this solve or what need does it fill?

Noticed that, when testing #12090, that Bevy does not have any spans for any of the tasks scheduled onto the IO and async compute task pols.

What solution would you like?

Preferably all tasks scheduled onto the task pools should have some top level spans, perhaps by instrumenting all incoming tasks. If that's too involved or too high overhead, we should at the very minimum instrument all asset loads.

What alternative(s) have you considered?

Leaving it be, shooting in the dark.

@james7132 james7132 added C-Enhancement A new feature A-Tasks Tools for parallel and async work labels Mar 14, 2024
@alice-i-cecile alice-i-cecile added the C-Performance A change motivated by improving speed, memory usage or compile times label Mar 14, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
# Objective

As described in #12467, Bevy does not have any spans for any of the
tasks scheduled onto the IO and async compute task pools.

## Solution

Instrument all asset loads and asset processing. Since this change is
restricted to asset tasks, it does not completely solve #12467, but it
does mean we can record the asset path in the trace.


![image](https://github.com/bevyengine/bevy/assets/8494645/59faee63-1f69-40af-bf47-312c4d67d1e2)

---

## Changelog

Tracing will now include spans for asset loading and asset processing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Enhancement A new feature C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Development

No branches or pull requests

2 participants