Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh2dHandle should have clone_weak and similar methods implemented #13001

Closed
alice-i-cecile opened this issue Apr 16, 2024 · 0 comments · Fixed by #13002
Closed

Mesh2dHandle should have clone_weak and similar methods implemented #13001

alice-i-cecile opened this issue Apr 16, 2024 · 0 comments · Fixed by #13002
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Mesh2dHandle is a thin wrapper over a Handle. It should expose all of the same methods.

What solution would you like?

Derive Deref.

What alternative(s) have you considered?

We could manually implement the methods, which improves docs, but is more annoying to maintain.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use labels Apr 16, 2024
@alice-i-cecile alice-i-cecile changed the title Mesh2dHandle should have CloneWeak and similar methods implemented Mesh2dHandle should have clone_weak and similar methods implemented Apr 16, 2024
@zuiyu1998 zuiyu1998 mentioned this issue Apr 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 18, 2024
@zuiyu1998
Added deref trait for Mesh2dHandle (#13002)
3fea726 
# Added deref trait for Mesh2dHandle

- Fixes #13001 ".

## Solution

- Added Derive Deref for Mesh2dHandle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds A-Rendering Drawing game state to the screen C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added deref trait for Mesh2dHandle zuiyu1998/bevy
1 participant
@alice-i-cecile