Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-version field to bevy_mikktspace #13183

Closed
BD103 opened this issue May 2, 2024 · 3 comments · Fixed by #13211
Closed

Add rust-version field to bevy_mikktspace #13183

BD103 opened this issue May 2, 2024 · 3 comments · Fixed by #13211
Labels
C-Docs An addition or correction to our documentation C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@BD103
Copy link
Member

BD103 commented May 2, 2024

bevy_mikktspace documents that it requires at least Rust 1.52.1.

bevy/crates/bevy_mikktspace/README.md

Line 13 in ff8a9b2

Requires at least Rust 1.52.1.

This should be codified by adding the rust-version field to Cargo.toml.
@BD103 BD103 added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A simple quality-of-life change that makes Bevy easier to use labels May 2, 2024
@BD103
Copy link
Member Author

BD103 commented May 2, 2024

Bonus points if you also check if any other crates do not specify a rust-version. :) (Most should say rust-version.workspace = true!)

@Brezak
Copy link
Contributor

Brezak commented May 3, 2024 •
edited

bevy_mikktspace is using the 2021 Rust edition. This makes it's minimum supported version Rust 1.56.0. The documentation will need to be updated.

@Brezak Brezak mentioned this issue May 3, 2024
Merged
@BD103
Copy link
Member Author

BD103 commented May 9, 2024

Bonus points if you also check if any other crates do not specify a rust-version. :) (Most should say rust-version.workspace = true!)

Turns out workspace-inherited properties are quite incompatible with our compile fail tests. If that were fixed, a lot of duplicated metadata could be merged...

github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
@Brezak
Determine msrv for every standalone bevy_* crate. (#13211)
cbda71c 
# Objective

As was pointed out in #13183, `bevy_mikktspace` is missing it's msrv
from it `Cargo.toml`. This promted me to check the msrv of every
`bevy_*` crate. Closes #13183.

## Solution

- Call `cargo check` with different rust versions on every bevy crate
until it doesn't complain.
- Write down the rust version `cargo check` started working.

## Testing

- Install `cargo-msrv`.
- Run `cargo msrv verify`.
- Rejoice.

---

## Changelog

Every published bevy crate now specifies a MSRV. If your rust toolchain
isn't at least version `1.77.0` You'll likely not be able to compile
most of bevy.

## Migration Guide

If your rust toolchain is bellow version`1.77.0, update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Docs An addition or correction to our documentation C-Usability A simple quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Determine msrv for every standalone bevy_* crate. Brezak/bevy
2 participants
@BD103 @Brezak