Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2d shapes demo Annulus not found #13324

Closed
parallaxisjones opened this issue May 10, 2024 · 4 comments
Closed

2d shapes demo Annulus not found #13324

parallaxisjones opened this issue May 10, 2024 · 4 comments
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled

Comments

@parallaxisjones
Copy link

parallaxisjones commented May 10, 2024

Bevy version

0.13.1
0.13.2

Relevant system information

2024-05-10T21:00:50.169484Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M3 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2024-05-10T21:00:50.323233Z  INFO bevy_winit::system: Creating new window "App" (0v1)
2024-05-10T21:00:50.347980Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "MacOS 14.1 ", kernel: "23.1.0", cpu: "Apple M3 Pro", core_count: "12", memory: "36.0 GiB" }

cargo 1.78.0 (54d8815d0 2024-03-26)

What you did

I copied the examples from 2d shapes, added bevy as a dependency, and then tried to run cargo build and cargo run

The following occurred

error[E0433]: failed to resolve: use of undeclared type `Annulus`
  --> src/main.rs:32:33
   |
32 |         Mesh2dHandle(meshes.add(Annulus::new(25.0, 50.0))),
   |                                 ^^^^^^^ use of undeclared type `Annulus`

What went wrong

To "fix" the issue, to get the example to build I had to remove the Annulus from the example code. I could not find a working version or feature that included the shape. am I missing something?

Additional information

[package]
name = "candlehopper"
version = "0.1.0"
edition = "2021"

# Enable a small amount of optimization in debug mode
[profile.dev]
opt-level = 1

# Enable high optimizations for dependencies (incl. Bevy), but not for our code:
[profile.dev.package."*"]
opt-level = 3

[workspace]
resolver = "2" # Important! wgpu/Bevy needs this!

[dependencies]
bevy = "0.13.1"
bevy_pancam = "0.11.0"
kd-tree = "0.5.3"
rand = "0.8.5"
typenum = "1.17.0"
@parallaxisjones parallaxisjones added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels May 10, 2024
@13ros27
Copy link
Contributor

13ros27 commented May 10, 2024

The Annulus shape (2d ring) was added since 0.13 (pr), however the examples on main are updated with all changes. Annulus will be in 0.14, if you want to see examples from previous versions you can go to that branch and check it out there, for example the 0.13 shapes.

@alice-i-cecile alice-i-cecile closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
@parallaxisjones
Copy link
Author

@13ros27 @alice-i-cecile Thank you for the info! Is there somewhere I can look to find information like that in the future? I'm just getting started with Bevy and was pulling my hair out for a moment trying to figure out what I was doing wrong. It seems a little strange to me to integrate unreleased features into the examples.

My hot take: that kind of thing is for sure likely to lead to un-needed issues getting created (like this one), and trip up newcomers (me). It's not at all obvious that I should have to go to previous versions to find a stable example to start from (or if it is, please educate me).

Thank you again!

@alice-i-cecile
Copy link
Member

Unfortunately this is largely a limitation of how Github works. The "default branch that contributors see and make PRs to" does not reflect the latest release. I've experimented elsewhere with a dev branch and it resulted in significant other confusion :(

We've attempted to make the warning as prominent as we can (see https://github.com/bevyengine/bevy/tree/main/examples#examples) and have even created our own examples outside of Github at https://bevyengine.org/examples/. On Github, looking at the latest tag resolves this as well.

@parallaxisjones
Copy link
Author

parallaxisjones commented May 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled
Projects
None yet
Development

No branches or pull requests

3 participants