Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reflect for all bevy_math types #13535

Closed
Olle-Lukowski opened this issue May 27, 2024 · 1 comment · Fixed by #13537
Closed

Implement Reflect for all bevy_math types #13535

Olle-Lukowski opened this issue May 27, 2024 · 1 comment · Fixed by #13537
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon

Comments

@Olle-Lukowski
Copy link
Contributor

Whilst writing the code for #13520, I noticed some types in bevy_math have no implementation of Reflect. I think we should ensure consistency, and simply implement it for all types there (if the optional bevy_reflect dependency is enabled).
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations X-Uncontroversial This work is generally agreed upon D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills labels May 27, 2024
@Olle-Lukowski
Copy link
Contributor Author

I'll get started on this now.

@Olle-Lukowski Olle-Lukowski mentioned this issue May 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 27, 2024
@Olle-Lukowski
Implemented Reflect for (almost) all bevy_math types (#13537)
d7fc20c 
# Objective

Fixes #13535.

## Solution

I implemented `Reflect` for close to all math types now, except for some
types that it would cause issues (like some boxed types).

## Testing

- Everything seems to still build, will await CI though.
---

## Changelog

- Made close to all math types implement `Reflect`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented Reflect for (almost) all bevy_math types Olle-Lukowski/bevy
2 participants
@alice-i-cecile @Olle-Lukowski