Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventReader:par_read doesn’t mark events as read #13821

Closed
BobG1983 opened this issue Jun 12, 2024 · 1 comment
Closed

EventReader:par_read doesn’t mark events as read #13821

BobG1983 opened this issue Jun 12, 2024 · 1 comment
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@BobG1983
Copy link
Contributor

Bevy version

Main (probably 0.14)

[Optional] Relevant system

bevy_ecs

What you did

Rewrote the test for par_read so it ran twice and checked the output after the second run to make sure that no events remained.

What went wrong

par_read saw the same events on the second system run.

Check the recent failed builds for my peekable and mutator pull requests for examples of the failing tests.
@BobG1983 BobG1983 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 12, 2024
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Jun 12, 2024
This was referenced Jun 13, 2024
Merged
Open
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 25, 2024
@BobG1983 @mnmaita
Mark events as read during EventReader::par_read (#13836)
4c3b4a4 
# Objective

- Fix issue #13821  

## Solution

- Rewrote the test to ensure that it actually tests the functionality
correctly. Then made the par_read function correctly change the values
of self.reader.last_event_count.

## Testing

- Rewrote the test for par_read to run the system schedule twice,
checking the output each time

---------

Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
cBournhonesque pushed a commit to cBournhonesque/bevy that referenced this issue Jun 25, 2024
@BobG1983 @mnmaita @cBournhonesque
Mark events as read during EventReader::par_read (bevyengine#13836)
10c450e 
# Objective

- Fix issue bevyengine#13821  

## Solution

- Rewrote the test to ensure that it actually tests the functionality
correctly. Then made the par_read function correctly change the values
of self.reader.last_event_count.

## Testing

- Rewrote the test for par_read to run the system schedule twice,
checking the output each time

---------

Co-authored-by: Martín Maita <47983254+mnmaita@users.noreply.github.com>
@mockersf
Copy link
Member

fixed in #13836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BobG1983 @alice-i-cecile @mockersf