Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to toml_edit from toml-rs for bevy_macro_utils #5675

Closed
Shatur opened this issue Aug 13, 2022 · 2 comments
Closed

Switch to toml_edit from toml-rs for bevy_macro_utils #5675

Shatur opened this issue Aug 13, 2022 · 2 comments
Labels
C-Dependencies A change to the crates that Bevy depends on C-Enhancement A new feature

Comments

@Shatur
Copy link
Contributor

Shatur commented Aug 13, 2022

What problem does this solve or what need does it fill?

toml-rs is unmaintained and it's a TOML 0.5 compliant parser.

What solution would you like?

It would be nice to use toml_edit. It's a drop-in replacement, actively maintained and supports TOML 1.0. For example, Cargo now use it.
@Shatur Shatur added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Aug 13, 2022
@Weibye Weibye added C-Dependencies A change to the crates that Bevy depends on and removed S-Needs-Triage This issue needs to be labelled labels Aug 14, 2022
@BorisBoutillier
Copy link
Contributor

I'd be happy to tackle the PR for this.
But before starting, I'd like to have a confirmation from a more senior bevy-dev that this is a meaningful move. ( seems so to me).

@mockersf
Copy link
Member

Makes sense to me to follow cargo 👍

@james7132 james7132 mentioned this issue Jan 22, 2023
Closed
@bors bors bot closed this as completed in 5f18033 Jan 22, 2023
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@james7132 @ItsDoot
Use toml_edit instead of toml (bevyengine#7327)
b32ff45 
# Objective
Fixes bevyengine#5675. Replace `toml` with `toml_edit`

## Solution
Replace `toml` with `toml_edit`. This conveniently also removes the `serde` dependency from `bevy_macro_utils`, which may speed up cold compilation by removing the serde bottleneck from most of the macro crates in the engine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Use toml_edit instead of toml james7132/bevy
4 participants
@mockersf @Weibye @BorisBoutillier @Shatur