Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSAO followup tracking issue #8888

Open
13 tasks
JMS55 opened this issue Jun 18, 2023 · 2 comments
Open
13 tasks

SSAO followup tracking issue #8888

JMS55 opened this issue Jun 18, 2023 · 2 comments
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature

Comments

@JMS55
Copy link
Contributor

JMS55 commented Jun 18, 2023 •
edited
Loading

SSAO got merged in #7402, but there's still a lot we can do better.

Performance

Quality

Platform Support

Recent Algorithm Advancements
@JMS55 JMS55 added C-Enhancement A new feature A-Rendering Drawing game state to the screen labels Jun 18, 2023
@JMS55 JMS55 added this to the 0.12 milestone Jun 18, 2023
@Elabajaba Elabajaba mentioned this issue Jun 27, 2023
Merged
3 tasks
@Elabajaba
Copy link
Contributor

The wgpu backport was released, so SSAO works on DX12 now!

We can get rid of the manual bitmask packing/unpacking implementations in the next wgpu release, as it should have the naga PR included.

@Elabajaba Elabajaba mentioned this issue Jul 29, 2023
Merged
@JMS55
Copy link
Contributor Author

JMS55 commented Sep 24, 2023

Open source reference we can use for visibility bitmasks: https://github.com/4lex4nder/ReshadeEffectShaderToggler-BG3/blob/main/Shaders/bg3_xegtao_gi.fx

@JMS55 JMS55 modified the milestones: 0.12, 0.13 Sep 28, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 9, 2023
@Elabajaba
wgpu 0.17 (#9302)
665dbcb 
~~Currently blocked on an upstream bug that causes crashes when
minimizing/resizing on dx12 gfx-rs/wgpu#3967
wgpu 0.17.1 is out which fixes it

# Objective

Keep wgpu up to date.

## Solution

Update wgpu and naga_oil.

Currently this depends on an unreleased (and unmerged) branch of
naga_oil, and hasn't been properly tested yet.

The wgpu side of this seems to have been an extremely trivial upgrade
(all the upgrade work seems to be in naga_oil). This also lets us remove
the workarounds for pack/unpack4x8unorm in the SSAO shaders.

Lets us close the dx12 part of
#8888

related: #9304

---

## Changelog

Update to wgpu 0.17 and naga_oil 0.9
regnarock pushed a commit to regnarock/bevy that referenced this issue Oct 13, 2023
@Elabajaba
wgpu 0.17 (bevyengine#9302)
8ada9d8 
~~Currently blocked on an upstream bug that causes crashes when
minimizing/resizing on dx12 gfx-rs/wgpu#3967
wgpu 0.17.1 is out which fixes it

# Objective

Keep wgpu up to date.

## Solution

Update wgpu and naga_oil.

Currently this depends on an unreleased (and unmerged) branch of
naga_oil, and hasn't been properly tested yet.

The wgpu side of this seems to have been an extremely trivial upgrade
(all the upgrade work seems to be in naga_oil). This also lets us remove
the workarounds for pack/unpack4x8unorm in the SSAO shaders.

Lets us close the dx12 part of
bevyengine#8888

related: bevyengine#9304

---

## Changelog

Update to wgpu 0.17 and naga_oil 0.9
ameknite pushed a commit to ameknite/bevy that referenced this issue Nov 6, 2023
@Elabajaba @ameknite
wgpu 0.17 (bevyengine#9302)
1c7854b 
~~Currently blocked on an upstream bug that causes crashes when
minimizing/resizing on dx12 gfx-rs/wgpu#3967
wgpu 0.17.1 is out which fixes it

Keep wgpu up to date.

Update wgpu and naga_oil.

Currently this depends on an unreleased (and unmerged) branch of
naga_oil, and hasn't been properly tested yet.

The wgpu side of this seems to have been an extremely trivial upgrade
(all the upgrade work seems to be in naga_oil). This also lets us remove
the workarounds for pack/unpack4x8unorm in the SSAO shaders.

Lets us close the dx12 part of
bevyengine#8888

related: bevyengine#9304

---

Update to wgpu 0.17 and naga_oil 0.9
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@Elabajaba
wgpu 0.17 (bevyengine#9302)
f643290 
~~Currently blocked on an upstream bug that causes crashes when
minimizing/resizing on dx12 gfx-rs/wgpu#3967
wgpu 0.17.1 is out which fixes it

# Objective

Keep wgpu up to date.

## Solution

Update wgpu and naga_oil.

Currently this depends on an unreleased (and unmerged) branch of
naga_oil, and hasn't been properly tested yet.

The wgpu side of this seems to have been an extremely trivial upgrade
(all the upgrade work seems to be in naga_oil). This also lets us remove
the workarounds for pack/unpack4x8unorm in the SSAO shaders.

Lets us close the dx12 part of
bevyengine#8888

related: bevyengine#9304

---

## Changelog

Update to wgpu 0.17 and naga_oil 0.9
@alice-i-cecile alice-i-cecile removed this from the 0.13 milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Elabajaba @alice-i-cecile @JMS55