Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken post processing after using MSAA for UI pass #9234

Closed
Elabajaba opened this issue Jul 21, 2023 · 0 comments · Fixed by #9237
Closed

Broken post processing after using MSAA for UI pass #9234

Elabajaba opened this issue Jul 21, 2023 · 0 comments · Fixed by #9237
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled

Comments

@Elabajaba
Copy link
Contributor

Bevy version

6093385

What you did

Run the SSAO and tonemapping examples.

What went wrong

Post processing isn't being applied.

Additional information

#9169 introduced the bug.

Looking at it with renderdoc, the UI pass appears to be overwriting the main_texture_(a/b) with the output of main_texture_sampled, which means it's discarding the results of tonemapping/bloom/other postprocessing.

Bloomy and tonemapped before the ui_pass:
image

UI pass overwrites it with the raw output from the main pass in main_texture_sampled:
image
@Elabajaba Elabajaba added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 21, 2023
@Elabajaba Elabajaba mentioned this issue Jul 22, 2023
Merged
@rparrett rparrett mentioned this issue Jul 24, 2023
Closed
github-merge-queue bot pushed a commit that referenced this issue Jul 25, 2023
@Elabajaba
Revert "Fix UI corruption for AMD gpus with Vulkan (#9169)" (#9237)
774fb56 
# Objective

Fixes #9234

re-breaks: The issues that were linked in #9169 

## Solution

Revert the PR that broke tonemapping/postprocessing/etc.

Any passes that are post msaa resolve need to use the main textures, not
the msaa texture.

## Changelog

Idk what to put here since it's a revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix UI corruption for AMD gpus with Vulkan (#9169)" Elabajaba/bevy
1 participant
@Elabajaba