Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate configure_set & make configure_sets work for single params. #9244

Closed
iiYese opened this issue Jul 22, 2023 · 1 comment · Fixed by #9247
Closed

Deprecate configure_set & make configure_sets work for single params. #9244

iiYese opened this issue Jul 22, 2023 · 1 comment · Fixed by #9247
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use

Comments

@iiYese
Copy link
Contributor

iiYese commented Jul 22, 2023

Bevy version

0.11

What you did

Tried to use .configure_sets with a single system set parameter.

What went wrong

Received a compile error. It seems configure_set was not deprecated and configure_sets was not changed to support single item calls like other APIs in this family for 0.11.
@iiYese iiYese added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jul 22, 2023
@urben1680
Copy link
Contributor

Worth noting that confiture_set exists both for App and Schedule.

@geieredgar geieredgar mentioned this issue Jul 23, 2023
Merged
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events A-App Bevy apps and plugins C-Usability A simple quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled C-Bug An unexpected or incorrect behavior labels Jul 27, 2023
github-merge-queue bot pushed a commit that referenced this issue Sep 5, 2023
@geieredgar @alice-i-cecile
Replace IntoSystemSetConfig with IntoSystemSetConfigs (#9247)
118509e 
# Objective

- Fixes #9244.

## Solution


- Changed the `(Into)SystemSetConfigs` traits and structs be more like
the `(Into)SystemConfigs` traits and structs.
- Replaced uses of `IntoSystemSetConfig` with `IntoSystemSetConfigs`
- Added generic `ItemConfig` and `ItemConfigs` types.
- Changed `SystemConfig(s)` and `SystemSetConfig(s)` to be type aliases
to `ItemConfig(s)`.
- Added generic `process_configs` to `ScheduleGraph`.
- Changed `configure_sets_inner` and `add_systems_inner` to reuse
`process_configs`.

---

## Changelog

- Added `run_if` to `IntoSystemSetConfigs`
- Deprecated `Schedule::configure_set` and `App::configure_set`
- Removed `IntoSystemSetConfig`

## Migration Guide

- Use `App::configure_sets` instead of `App::configure_set`
- Use `Schedule::configure_sets` instead of `Schedule::configure_set`

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@geieredgar @alice-i-cecile
Replace IntoSystemSetConfig with IntoSystemSetConfigs (bevyengine…
86d8fdc 
…#9247)

# Objective

- Fixes bevyengine#9244.

## Solution


- Changed the `(Into)SystemSetConfigs` traits and structs be more like
the `(Into)SystemConfigs` traits and structs.
- Replaced uses of `IntoSystemSetConfig` with `IntoSystemSetConfigs`
- Added generic `ItemConfig` and `ItemConfigs` types.
- Changed `SystemConfig(s)` and `SystemSetConfig(s)` to be type aliases
to `ItemConfig(s)`.
- Added generic `process_configs` to `ScheduleGraph`.
- Changed `configure_sets_inner` and `add_systems_inner` to reuse
`process_configs`.

---

## Changelog

- Added `run_if` to `IntoSystemSetConfigs`
- Deprecated `Schedule::configure_set` and `App::configure_set`
- Removed `IntoSystemSetConfig`

## Migration Guide

- Use `App::configure_sets` instead of `App::configure_set`
- Use `Schedule::configure_sets` instead of `Schedule::configure_set`

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace IntoSystemSetConfig with IntoSystemSetConfigs geieredgar/bevy
3 participants
@alice-i-cecile @urben1680 @iiYese