Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directories support on android #9968

Open
deltanedas opened this issue Sep 29, 2023 · 0 comments · May be fixed by #11495
Open

directories support on android #9968

deltanedas opened this issue Sep 29, 2023 · 0 comments · May be fixed by #11495
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Enhancement A new feature O-Android Specific to the Android mobile operating system

Comments

@deltanedas
Copy link

deltanedas commented Sep 29, 2023 •
edited
Loading

What problem does this solve or what need does it fill?

read_directory and is_directory are not implemented on android
the former i believe is a regression as i believe in 0.11 you can at least check a files metadata

What solution would you like?

yep directories on android are still directories surely the android assets api allows for readdir and stat

(https://docs.rs/ndk/latest/ndk/asset/struct.AssetManager.html#method.open_dir)

What alternative(s) have you considered?

no

Additional context

part of #9591 but this issue is purely android since im fairly sure it can be implemented
also its changed slightly since asset v2 may have lost is_dir -> is_directory functionality
@deltanedas deltanedas added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Sep 29, 2023
@deltanedas deltanedas mentioned this issue Sep 29, 2023
Closed
@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds O-Android Specific to the Android mobile operating system and removed S-Needs-Triage This issue needs to be labelled labels Sep 29, 2023
esensar added a commit to esensar/bevy that referenced this issue Jan 23, 2024
@esensar
Add directory related functions to AndroidAssetReader
46762ef 
This fixes bevyengine#9968
@esensar esensar linked a pull request Jan 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Enhancement A new feature O-Android Specific to the Android mobile operating system
Projects
None yet
Milestone
No milestone
2 participants
@mockersf @deltanedas