Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unlit missing parameters #10144

Merged
merged 1 commit into from Oct 16, 2023
Merged

Fix unlit missing parameters #10144

merged 1 commit into from Oct 16, 2023

Conversation

DGriffin91
Copy link
Contributor

Objective

Solution

  • Add them back

@alice-i-cecile alice-i-cecile added this to the 0.12 milestone Oct 16, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Oct 16, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 16, 2023
@mockersf mockersf added this pull request to the merge queue Oct 16, 2023
Merged via the queue into bevyengine:main with commit 490699c Oct 16, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@DGriffin91 @ameknite
Fix unlit missing parameters (bevyengine#10144)
59b7ce4 
# Objective

- The refactoring in bevyengine#10105
missed including the frag_coord and normal in pbr_input.

## Solution

- Add them back
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@DGriffin91
Fix unlit missing parameters (bevyengine#10144)
b400116 
# Objective

- The refactoring in bevyengine#10105
missed including the frag_coord and normal in pbr_input.

## Solution

- Add them back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceSentry IceSentry IceSentry approved these changes

@mockersf mockersf mockersf approved these changes

@robtfm robtfm robtfm approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DGriffin91 @IceSentry @mockersf @robtfm @alice-i-cecile