Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_texture example: use new name of pbr function #10168

Merged
merged 1 commit into from Oct 18, 2023
Merged

array_texture example: use new name of pbr function #10168

merged 1 commit into from Oct 18, 2023

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Use the new name of the function in the shader

@mockersf mockersf added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Oct 17, 2023
@mockersf mockersf added this to the 0.12 milestone Oct 17, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 17, 2023
@mockersf mockersf added this pull request to the merge queue Oct 18, 2023
Merged via the queue into bevyengine:main with commit f6003c3 Oct 18, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
array_texture example: use new name of pbr function (bevyengine#10168)
ccd78c6 
# Objective

- After bevyengine#7820 example `array_texture` doesn't display anything

## Solution

- Use the new name of the function in the shader
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
array_texture example: use new name of pbr function (bevyengine#10168)
940e2c8 
# Objective

- After bevyengine#7820 example `array_texture` doesn't display anything

## Solution

- Use the new name of the function in the shader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@robtfm robtfm robtfm approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mockersf @alice-i-cecile @robtfm