Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add on_real_time_timer run condition #10179

Merged
merged 2 commits into from Oct 20, 2023
Merged

add on_real_time_timer run condition #10179

merged 2 commits into from Oct 20, 2023

Conversation

SecretPocketCat
Copy link
Contributor

Objective

Fixes #10177 .

Solution

Added a new run condition and tweaked the docs for on_timer.

Changelog

Added

  • on_real_time_timer run condition

@SecretPocketCat
Copy link
Contributor Author

The name is probably not the best.

I'm also not super sure if the reference to relative_speed in the updated docs is correct.

@alice-i-cecile
Copy link
Member

on_real_timer perhaps?

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use A-Time Involves time keeping and reporting labels Oct 18, 2023
@SecretPocketCat
Copy link
Contributor Author

on_real_timer perhaps?

That was my first though. I thought on_real_time_timer but you are right and it probly isn't.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 20, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 20, 2023
Merged via the queue into bevyengine:main with commit b1cc7ad Oct 20, 2023
22 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@SecretPocketCat @ameknite
add on_real_time_timer run condition (bevyengine#10179)
372734a 
# Objective

Fixes bevyengine#10177 .

## Solution

Added a new run condition and tweaked the docs for `on_timer`.

## Changelog

### Added 
 - `on_real_time_timer` run condition
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@SecretPocketCat
add on_real_time_timer run condition (bevyengine#10179)
1d6e53d 
# Objective

Fixes bevyengine#10177 .

## Solution

Added a new run condition and tweaked the docs for `on_timer`.

## Changelog

### Added 
 - `on_real_time_timer` run condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Time Involves time keeping and reporting C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Real/unscaled time timer run condition
3 participants
@SecretPocketCat @alice-i-cecile @james7132