Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all usages of texture_descritor.size.* with the helper methods #10227

Merged
merged 5 commits into from Oct 23, 2023
Merged

Replace all usages of texture_descritor.size.* with the helper methods #10227

merged 5 commits into from Oct 23, 2023

Conversation

st0rmbtw
Copy link
Contributor

Objective

A follow-up PR for #10221

Changelog

Replaced usages of texture_descriptor.size with the helper methods of Image through the entire engine codebase

@mockersf
Copy link
Member

Could you mark the functions as inline?

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Oct 22, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 23, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 23, 2023
Merged via the queue into bevyengine:main with commit afe8b5f Oct 23, 2023
24 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@st0rmbtw @ameknite
Replace all usages of texture_descritor.size.* with the helper methods (
4022c3e 
bevyengine#10227)

# Objective

A follow-up PR for bevyengine#10221

## Changelog

Replaced usages of texture_descriptor.size with the helper methods of
`Image` through the entire engine codebase
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@st0rmbtw
Replace all usages of texture_descritor.size.* with the helper methods (
6f264b2 
bevyengine#10227)

# Objective

A follow-up PR for bevyengine#10221

## Changelog

Replaced usages of texture_descriptor.size with the helper methods of
`Image` through the entire engine codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@st0rmbtw @mockersf @james7132 @alice-i-cecile