Use shaderc for aarch64-apple-darwin. #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frewsxcv
commented
Dec 8, 2020
| pub fn glsl_to_spirv( | ||
| glsl_source: &str, | ||
| stage: ShaderStage, | ||
| shader_defs: Option<&[String]>, | ||
| ) -> Result<Vec<u32>, ShaderError> { | ||
| let mut compiler = shaderc::Compiler::new()?; | ||
| let mut options = shaderc::CompileOptions::new()?; |
There was a problem hiding this comment.
These lines were not compiling prior to my pull request. Both of these lines return Option, whereas the function signature returns Result.
Closed
Moxinilian
added
C-Enhancement
|
Looks good to me. Thanks! |
|
I'd love to make shaderc an optional feature, then selectively enable it for specific platforms. This would clean the code/config significantly and enable people to opt in to shaderc on any platform. But cargo won't let us do that afaik: rust-lang/cargo#1197 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @cart and @mockersf in #928, this pull request switches Apple Silicon devices to use shaderc instead of bevy-glsl-to-spirv. This change, along with the latest unreleased version of winit (rust-windowing/winit#1789), gets Bevy working on Apple Silicon!