Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float precision issue in the gizmo shader #10408

Merged
merged 2 commits into from Nov 14, 2023

Conversation

irate-devil
Copy link
Contributor

@irate-devil irate-devil commented Nov 6, 2023

Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~ units) in my testing.

Fixes #10403

@alice-i-cecile alice-i-cecile added this to the 0.12.1 milestone Nov 6, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! A-Gizmos Visual editor and debug gizmos labels Nov 6, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 14, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 14, 2023
Merged via the queue into bevyengine:main with commit 7b2213a Nov 14, 2023
26 checks passed
cart pushed a commit that referenced this pull request Nov 30, 2023
Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~
units) in my testing.

Fixes #10403
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~
units) in my testing.

Fixes bevyengine#10403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior C-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: gizmo lines with vertices behind camera display artifacts
4 participants