Rename Timer::{percent,percent_left} to Timer::{fraction,fraction_remaining}
#10442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 8, 2023
alice-i-cecile
added
C-Usability
|
While we're renaming, why not name it |
mamekoro
changed the title
Timer::{percent,percent_left} to Timer::{fraction,fraction_left}Timer::{percent,percent_left} to Timer::{fraction,fraction_remaining}
soqb
approved these changes
Nov 9, 2023
alice-i-cecile
approved these changes
Nov 9, 2023
hymm
added
the
S-Ready-For-Final-Review
|
0.12 release just added Should that be included in this PR or should it be another one? |
I would prefer in this PR 👍 |
|
#10448 will rename |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…remaining}` (bevyengine#10442) # Objective Fixes bevyengine#10439 `Timer::percent()` and `Timer::percent_left()` return values in the range of 0.0 to 1.0, even though their names contain "percent". These functions should be renamed for clarity. ## Solution - Rename `Timer::percent()` to `Timer::fraction()` - Rename `Timer::percent_left()` to `Timer::fraction_remaining()` --- ## Changelog ### Changed - Renamed `Timer::percent()` to `Timer::fraction()` - Renamed `Timer::percent_left()` to `Timer::fraction_remaining()` ## Migration Guide - `Timer::percent()` has been renamed to `Timer::fraction()` - `Timer::percent_left()` has been renamed to `Timer::fraction_remaining()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #10439
Timer::percent()andTimer::percent_left()return values in the range of 0.0 to 1.0, even though their names contain "percent".These functions should be renamed for clarity.
Solution
Timer::percent()toTimer::fraction()Timer::percent_left()toTimer::fraction_remaining()Changelog
Changed
Timer::percent()toTimer::fraction()Timer::percent_left()toTimer::fraction_remaining()Migration Guide
Timer::percent()has been renamed toTimer::fraction()Timer::percent_left()has been renamed toTimer::fraction_remaining()