Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary if statement in scheduler #10446

Merged
merged 1 commit into from Nov 9, 2023
Merged

Remove unnecessary if statement in scheduler #10446

merged 1 commit into from Nov 9, 2023

Conversation

DasLixou
Copy link
Contributor

@DasLixou DasLixou commented Nov 8, 2023

Objective

There is an if statement checking if a node is present in a graph moments after it explicitly being added.
Unless the edge function has super weird side effects and the tests don't pass, this is unnecessary.

Solution

Removed it

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Nov 8, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 8, 2023
@james7132 james7132 added this pull request to the merge queue Nov 9, 2023
Merged via the queue into bevyengine:main with commit 003765a Nov 9, 2023
26 checks passed
@DasLixou DasLixou deleted the patch-3 branch November 9, 2023 06:34
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@DasLixou
Remove unnecessary if statement in scheduler (bevyengine#10446)
12ba864 
# Objective

There is an if statement checking if a node is present in a graph
moments after it explicitly being added.
Unless the edge function has super weird side effects and the tests
don't pass, this is unnecessary.

## Solution

Removed it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DasLixou @james7132 @alice-i-cecile @irate-devil