Add discard_overstep function to Time<Fixed> #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Nov 9, 2023
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
atlv24
approved these changes
Nov 18, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
NiseVoid
added a commit
to NiseVoid/bevy
that referenced
this pull request
Dec 16, 2023
# Objective There is no easy way to discard some amount for `Time<Fixed>`'s overstep. This can be useful for online games when the client receives information about a tick (which happens when you get a FPS drop or the ping changes for example) it has not yet processed, it can discard overstep equal to the number of ticks it can jump ahead. Currently the workaround would be to create a new `Time<Fixed>` copy the old timestep, advance it by the overstep amount that would remain after subtracting the discarded amount, and using `.context_mut()` to overwrite the old context with the new one. If you overwrite the whole `Time<Fixed>` or forget to copy over the timestep you can introduce undesirable side effects. ## Solution Introduce a `discard_overstep` method, which discards the provided amount of overstep. It uses satuarting_sub to avoid errors (negative `Duration`s do not exist). --- ## Changelog - Added `discard_overstep` function to `Time<Fixed>` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective There is no easy way to discard some amount for `Time<Fixed>`'s overstep. This can be useful for online games when the client receives information about a tick (which happens when you get a FPS drop or the ping changes for example) it has not yet processed, it can discard overstep equal to the number of ticks it can jump ahead. Currently the workaround would be to create a new `Time<Fixed>` copy the old timestep, advance it by the overstep amount that would remain after subtracting the discarded amount, and using `.context_mut()` to overwrite the old context with the new one. If you overwrite the whole `Time<Fixed>` or forget to copy over the timestep you can introduce undesirable side effects. ## Solution Introduce a `discard_overstep` method, which discards the provided amount of overstep. It uses satuarting_sub to avoid errors (negative `Duration`s do not exist). --- ## Changelog - Added `discard_overstep` function to `Time<Fixed>` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is no easy way to discard some amount for
Time<Fixed>'s overstep. This can be useful for online games when the client receives information about a tick (which happens when you get a FPS drop or the ping changes for example) it has not yet processed, it can discard overstep equal to the number of ticks it can jump ahead.Currently the workaround would be to create a new
Time<Fixed>copy the old timestep, advance it by the overstep amount that would remain after subtracting the discarded amount, and using.context_mut()to overwrite the old context with the new one. If you overwrite the wholeTime<Fixed>or forget to copy over the timestep you can introduce undesirable side effects.Solution
Introduce a
discard_overstepmethod, which discards the provided amount of overstep. It uses satuarting_sub to avoid errors (negativeDurations do not exist).Changelog
discard_overstepfunction toTime<Fixed>