Remove a ptr-to-int cast in CommandQueue::apply
#10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Nov 9, 2023
MrGVSV
approved these changes
Nov 9, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Nov 9, 2023
james7132
approved these changes
Nov 9, 2023
|
Adding to the milestone because #10746 builds on these changes |
cart
pushed a commit
that referenced
this pull request
Nov 30, 2023
# Objective - `CommandQueue::apply` calculates the address of the end of the internal buffer as a `usize` rather than as a pointer, requiring two casts of `cursor` to `usize`. Casting pointers to integers is generally discouraged and may also prevent optimizations. It's also unnecessary here. ## Solution - Calculate the end address as a pointer rather than a `usize`. Small note: A trivial translation of the old code to use pointers would have computed `end_addr` as `cursor.add(self.bytes.len())`, which is not wrong but is an additional `unsafe` operation that also needs to be properly documented and proven correct. However this operation is already implemented in the form of the safe `as_mut_ptr_range`, so I just used that.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - `CommandQueue::apply` calculates the address of the end of the internal buffer as a `usize` rather than as a pointer, requiring two casts of `cursor` to `usize`. Casting pointers to integers is generally discouraged and may also prevent optimizations. It's also unnecessary here. ## Solution - Calculate the end address as a pointer rather than a `usize`. Small note: A trivial translation of the old code to use pointers would have computed `end_addr` as `cursor.add(self.bytes.len())`, which is not wrong but is an additional `unsafe` operation that also needs to be properly documented and proven correct. However this operation is already implemented in the form of the safe `as_mut_ptr_range`, so I just used that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
CommandQueue::applycalculates the address of the end of the internal buffer as ausizerather than as a pointer, requiring two casts ofcursortousize. Casting pointers to integers is generally discouraged and may also prevent optimizations. It's also unnecessary here.Solution
usize.Small note:
A trivial translation of the old code to use pointers would have computed
end_addrascursor.add(self.bytes.len()), which is not wrong but is an additionalunsafeoperation that also needs to be properly documented and proven correct. However this operation is already implemented in the form of the safeas_mut_ptr_range, so I just used that.