Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export ron in bevy_scene #10529

Merged
merged 4 commits into from
Nov 15, 2023
Merged

Re-export ron in bevy_scene #10529

merged 4 commits into from
Nov 15, 2023

Conversation

JoJoJet
Copy link
Member

@JoJoJet JoJoJet commented Nov 13, 2023

Objective

Close #10504. Improve the development experience for working with scenes by not requiring the user to specify a matching version of ron in their Cargo.toml

killercup
killercup reviewed Nov 13, 2023
View reviewed changes
Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to also update the examples to use this reexport instead of the crate?

@alice-i-cecile
Copy link
Member

Once the example(s) are updated, this LGTM.

@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Scenes Serialized ECS data stored on the disk labels Nov 14, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 15, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 15, 2023
Merged via the queue into bevyengine:main with commit dcfae72 Nov 15, 2023
25 checks passed
@JoJoJet JoJoJet deleted the export-ron branch November 15, 2023 18:27
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@JoJoJet @alice-i-cecile
Re-export ron in bevy_scene (bevyengine#10529)
462dff1 
# Objective

Close bevyengine#10504. Improve the development experience for working with scenes
by not requiring the user to specify a matching version of `ron` in
their `Cargo.toml`

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-export ron from Bevy
3 participants
@JoJoJet @alice-i-cecile @killercup