Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Debug, PartialEq and Eq derives to bevy_animation. #10562

Merged
merged 1 commit into from Nov 15, 2023
Merged

Add Debug, PartialEq and Eq derives to bevy_animation. #10562

merged 1 commit into from Nov 15, 2023

Conversation

AxiomaticSemantics
Copy link
Contributor

Objective

  • Add Debug PartialEq and Eq impl's to RepeatAnimation

Solution

  • Add the wanted derives.

@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time labels Nov 15, 2023
killercup
killercup approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Whenever I see this kind of PR I'd really want to know what the use case was that brought this on. And why not derive Hash as well? 😅

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 15, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 15, 2023
Merged via the queue into bevyengine:main with commit 8c15713 Nov 15, 2023
25 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@AxiomaticSemantics
Add Debug, PartialEq and Eq derives to bevy_animation. (bevyengine#10562
0689f4c 
)

# Objective

- Add `Debug` `PartialEq` and `Eq` impl's to `RepeatAnimation`

## Solution

- Add the wanted derives.

Co-authored-by: ebola <dev@axiomatic>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Animation Make things move and change over time C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AxiomaticSemantics @killercup @alice-i-cecile