prepass vertex shader always outputs world position #10657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robtfm
changed the title
robtfm
added
C-Bug
superdump
approved these changes
Nov 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Btw, driver shader compilers (usually based on LLVM) should do dead code elimination very well. We probably don't need shaderdefs for some of these things. |
IceSentry
approved these changes
Nov 20, 2023
JMS55
approved these changes
Nov 20, 2023
james7132
added
the
S-Ready-For-Final-Review
|
Can you please rebase / merge in main to get the latest CI check running on your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
the pbr prepass vertex shader currently only sets
VertexOutput::world_positionwhen deferred or motion prepasses are enabled.the field is always in the vertex output so is otherwise undetermined, and the calculation is very cheap.
Solution
always set the world position in the pbr prepass vert shader.