Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc example for Ref #10682

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Rustdoc example for Ref #10682

merged 1 commit into from
Nov 22, 2023

Conversation

stepancheg
Copy link
Contributor

No description provided.

@ItsDoot ItsDoot added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Nov 21, 2023
@hymm hymm added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 22, 2023
@rlidwka
Copy link
Contributor

rlidwka commented Nov 22, 2023

If you compare two things (even for the sake of the example), the difference between them usually deserves a mention.

Are those exactly equivalent, or are there performance implications for doing filtering inside the system? Would you ever want to write Query<Ref<MyComponent>, Changed<MyComponent>>?

Also, first query fetches Entity and second doesn't, not sure if that's relevant. Maybe adding Entity to second query or removing it from the first will create less confusion if people start copy-pasting things.

@stepancheg
Copy link
Contributor Author

@rlidwka

Are those exactly equivalent, or are there performance implications for doing filtering inside the system?

I would appreciate if you suggest better wording, or just submit a better PR with better explanations.

@stepancheg
Copy link
Contributor Author

Removed entity from first example.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 22, 2023
Merged via the queue into bevyengine:main with commit b0cc6bf Nov 22, 2023
22 checks passed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants