Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bevy_app and reflect opt-out for bevy_hierarchy. #10721

Merged
merged 2 commits into from Nov 25, 2023

Conversation

mintlu8
Copy link
Contributor

@mintlu8 mintlu8 commented Nov 24, 2023

Objective

Bevy_hierarchy is very useful for ECS only usages of bevy_ecs, but it currently pulls in bevy_reflect, bevy_app and bevy_core with no way to opt out.

Solution

This PR provides features bevy_app and reflect that are enabled by default. If disabled, they should remove these dependencies from bevy_hierarchy.


Changelog

Added features bevy_app and reflect to bevy_hierarchy.

@Kanabenki Kanabenki added C-Usability A simple quality-of-life change that makes Bevy easier to use A-Hierarchy Parent-child entity hierarchies labels Nov 24, 2023
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. This is something I'd like to see more of in our crates :)

Getting the config right for the optional dependencies is tricky, but it looks to me like you've done it. Criteria for me are:

  1. Nice granular features.
  2. Same default behavior.
  3. No default features works well with raw bevy_ecs.

@alice-i-cecile
Copy link
Member

alice-i-cecile commented Nov 24, 2023

It's complaining about the formatting of your toml files: you'll have to clean that up before we can merge :)

Ah, it's actually another problem.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 25, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 25, 2023
Merged via the queue into bevyengine:main with commit c33bacd Nov 25, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Hierarchy Parent-child entity hierarchies C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants