Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate QueryState::for_each_unchecked #10815

Merged
merged 1 commit into from Dec 1, 2023
Merged

Deprecate QueryState::for_each_unchecked #10815

merged 1 commit into from Dec 1, 2023

Conversation

asuratos
Copy link
Contributor

Objective

Resolves Issue #10772.

Solution

Added the deprecated warning for QueryState::for_each_unchecked, as noted in the comments of PR #6773.
Followed the wording in the deprecation messages for for_each and for_each_mut

@asuratos
Copy link
Contributor Author

The PR in question hasn't been merged yet, so the changes to for_each and related functions aren't in this PR.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 30, 2023
@alice-i-cecile
Copy link
Member

Thank you! I'm going to wait to merge this until the linked PR gets in.

@james7132 james7132 added this pull request to the merge queue Dec 1, 2023
Merged via the queue into bevyengine:main with commit cbf39b7 Dec 1, 2023
26 checks passed
@asuratos asuratos deleted the deprecate-for-each-unchecked-manual branch December 3, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asuratos @alice-i-cecile @james7132