Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove identity map calls #10848

Merged
merged 1 commit into from Dec 4, 2023
Merged

Remove identity map calls #10848

merged 1 commit into from Dec 4, 2023

Conversation

Nilirad
Copy link
Contributor

@Nilirad Nilirad commented Dec 2, 2023

Removes calls to Iterator::map that don't do any work.

@Nilirad Nilirad added the C-Code-Quality A section of code that is hard to understand or change label Dec 2, 2023
JoJoJet
JoJoJet approved these changes Dec 2, 2023
View reviewed changes
crates/bevy_app/src/app.rs Show resolved Hide resolved
@Nilirad Nilirad added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 3, 2023
@mockersf mockersf added this pull request to the merge queue Dec 4, 2023
Merged via the queue into bevyengine:main with commit c936873 Dec 4, 2023
25 checks passed
@Nilirad Nilirad deleted the unmap branch December 5, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@irate-devil irate-devil irate-devil approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nilirad @mockersf @JoJoJet @irate-devil