Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment about scale factor in WindowMode #10872

Merged
merged 2 commits into from Dec 5, 2023
Merged

Add comment about scale factor in WindowMode #10872

merged 2 commits into from Dec 5, 2023

Conversation

matiqo15
Copy link
Member

@matiqo15 matiqo15 commented Dec 4, 2023

Objective

Solution

Changelog

Add a comment about scaling behavior that happens, and point user to how he can avoid that behavior.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Windowing Platform-agnostic interface layer to run your app in labels Dec 4, 2023
ickshonpe
ickshonpe suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

crates/bevy_window/src/window.rs Outdated Show resolved Hide resolved
crates/bevy_window/src/window.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 5, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 5, 2023
Merged via the queue into bevyengine:main with commit 5508915 Dec 5, 2023
23 checks passed
@matiqo15 matiqo15 mentioned this pull request Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ickshonpe ickshonpe ickshonpe approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Borderless fullscreen physical resolution incorrectly affected by system ui scale
3 participants
@matiqo15 @alice-i-cecile @ickshonpe