Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate systems in bevy_audio #10906

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Deduplicate systems in bevy_audio #10906

merged 1 commit into from
Dec 7, 2023

Conversation

irate-devil
Copy link
Contributor

@irate-devil irate-devil commented Dec 7, 2023 •
edited
Loading

Objective

The update_emitter_positions, and update_listener_positions systems are added for every call to add_audio_source.
Instead, add them once in the AudioPlugin directly.

Also merged the calls to add_systems.

Caught while working on my schedule visualizer c:

@james7132 james7132 added A-Audio Sounds playback and modification C-Code-Quality A section of code that is hard to understand or change labels Dec 7, 2023
@james7132 james7132 added this pull request to the merge queue Dec 7, 2023
Merged via the queue into bevyengine:main with commit a4c2728 Dec 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Code-Quality A section of code that is hard to understand or change
Projects
Audio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@irate-devil @hymm @james7132