Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how RegularPolygon mesh is generated #10927

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

stepancheg
Copy link
Contributor

I didn't notice minus where vertices are generated, so could not understand the order there.

Adding a comment to help the next person who is going to understand Bevy by reading its code.

@matiqo15 matiqo15 added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change and removed C-Docs An addition or correction to our documentation labels Dec 10, 2023
Copy link
Contributor

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on mesh generation for primitives and have changed some things around, so this might get changed later if the new implementations get approved. Here for example, my implementation just adds the actual vertices in CCW order, so you don't need to reverse the indices.

Useful comment to have for now though, no objections against it

Edit: Accidentally said CW, meant the opposite haha

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 12, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 12, 2023
Merged via the queue into bevyengine:main with commit ff7497c Dec 12, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants