Give UI nodes with Display::None
an empty clipping rect
#10942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Outlines are drawn for UI nodes with
Display::None
set and their descendants. They should not be visible.Solution
Make all Nodes with
Display::None
inherit an empty clipping rect, ensuring that the outlines are not visible.Fixes #10940
Changelog
update_clipping_system
if a node hasDisplay::None
set, clip the entire node and all its descendants by replacing the inherited clip with a default rect (which is empty)