Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add html tags required for accessibility #10989

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Add html tags required for accessibility #10989

merged 1 commit into from
Dec 16, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 15, 2023

Objective

  • Make example comply with accessibility standards.

Solution

  • Add missing tags.

@matiqo15 matiqo15 added the C-Examples An addition or correction to our examples label Dec 15, 2023
@alice-i-cecile alice-i-cecile added the A-Accessibility A problem that prevents users with disabilities from using Bevy label Dec 16, 2023
thepackett
thepackett approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@thepackett thepackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the language to the html tag is always recommended for accessibility (source: w3schools), and always having a title is a good idea too. Moving the background-repeat property into the background property shorthand is unrelated to accessibility, but there's also no reason not to. Overall these changes are good and I don't see any reason not to accept them as is.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 16, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 16, 2023
Merged via the queue into bevyengine:main with commit 746361b Dec 16, 2023
26 checks passed
@tygyh tygyh deleted the fix-html-accessibility branch December 16, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepackett thepackett thepackett approved these changes

@ItsDoot ItsDoot ItsDoot approved these changes

@matiqo15 matiqo15 matiqo15 approved these changes

Assignees
No one assigned
Labels
A-Accessibility A problem that prevents users with disabilities from using Bevy C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tygyh @thepackett @ItsDoot @matiqo15 @alice-i-cecile