Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base64 padding when loading a gltf file #11053

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 21, 2023

Objective

Solution

  • Allow padding in base 64 decoder

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Assets Load files from disk to use for things like images, models, and sounds labels Dec 21, 2023
@mgi388
Copy link
Contributor

mgi388 commented Dec 21, 2023

Out of interest, more for my own curiosity, is this change a good candidate for a test to protect against further regressions?

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good candidate for a regression test. It would involve working with assets though: I'm not sure of the best way to set that up.

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Dec 21, 2023
@mockersf
Copy link
Member Author

Now that asset v2 is done, finally working on testable asset loaders should happen

There is an extra safety net after Bevy CI: http://thebevyflock.github.io/bevy-example-runner/ which runs most examples regularly and check their screenshots. This is how I noticed the issue.

@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 21, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 21, 2023
Merged via the queue into bevyengine:main with commit 8666b07 Dec 21, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants