Update sysinfo version to 0.30.0 #11071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Dec 22, 2023
matiqo15
approved these changes
Dec 23, 2023
matiqo15
added
the
S-Ready-For-Final-Review
james7132
approved these changes
Dec 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
# Objective sysinfo was updated to 0.30 in #11071. Ever since then the `cpu` field of the `SystemInfo` struct that gets printed every time one starts an bevy app has been empty. This is because the following part of the sysinfo migration guide was overlooked: --- ### `Cpu` changes Information like `Cpu::brand`, `Cpu::vendor_id` or `Cpu::frequency` are not set on the "global" CPU. --- ## Solution - Get the CPU brand information from a specific CPU instead. In this case, just choose the first one. It's theoretically possible for different CPUs to have different names, but in practice this doesn't really happen I think. Even Intel's newer hybrid processors use a uniform name for all CPUs in my experience. - We can use this opportunity to also update our `sysinfo::System` initialization here to only fetch the information we're interested in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version comes with a lot of improvements. Full list is available there: https://github.com/GuillaumeGomez/sysinfo/blob/master/migration_guide.md