Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder impl to be the same as the trait #11076

Merged
merged 1 commit into from Dec 24, 2023
Merged

Reorder impl to be the same as the trait #11076

merged 1 commit into from Dec 24, 2023

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 23, 2023

Objective

  • Make the implementation order consistent between all sources to fit the order in the trait.

Solution

  • Change the implementation order.

@Nilirad Nilirad added the C-Code-Quality A section of code that is hard to understand or change label Dec 23, 2023
alice-i-cecile
alice-i-cecile approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as trivial.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 24, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 24, 2023
Merged via the queue into bevyengine:main with commit 1568d4a Dec 24, 2023
25 checks passed
@tygyh tygyh deleted the Reorder-impl branch December 25, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tygyh @alice-i-cecile @Nilirad