Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor collide code (Adopted) #11106

Merged
merged 1 commit into from Jan 1, 2024
Merged

refactor collide code (Adopted) #11106

merged 1 commit into from Jan 1, 2024

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Dec 27, 2023

Objective

  • Refactor collide code and add tests.

Solution

@Nilirad Nilirad added C-Code-Quality A section of code that is hard to understand or change A-Physics Collisions, kinematics, forces and more labels Dec 27, 2023
@alice-i-cecile
Copy link
Member

@mnmaita want to review this for us?

mnmaita
mnmaita approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@mnmaita mnmaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 30, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 1, 2024
Merged via the queue into bevyengine:main with commit 55c9958 Jan 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mnmaita mnmaita mnmaita approved these changes

Assignees
No one assigned
Labels
A-Physics Collisions, kinematics, forces and more C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tygyh @alice-i-cecile @mnmaita @Nilirad