Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl ExclusiveSystemParam for WorldId #11164

Merged
merged 1 commit into from
Jan 1, 2024
Merged

impl ExclusiveSystemParam for WorldId #11164

merged 1 commit into from
Jan 1, 2024

Conversation

stepancheg
Copy link
Contributor

@stepancheg stepancheg commented Jan 1, 2024 •
edited by james7132
Loading

Objective

Mostly for consistency.

Solution

impl ExclusiveSystemParam for WorldId
  • Also add a test for SystemParam for WorldId

Changelog

Added: Worldd now implements ExclusiveSystemParam.

alice-i-cecile
alice-i-cecile approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have tests for this.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use labels Jan 1, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 1, 2024
@james7132 james7132 added this pull request to the merge queue Jan 1, 2024
Merged via the queue into bevyengine:main with commit 9f397d0 Jan 1, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stepancheg @james7132 @alice-i-cecile @JoJoJet