Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "AddChild" to "PushChild" #11194

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Rename "AddChild" to "PushChild" #11194

merged 3 commits into from
Jan 4, 2024

Conversation

garychia
Copy link
Contributor

@garychia garychia commented Jan 3, 2024 •
edited
Loading

Objective

Solution

  • Rename the AddChild struct to PushChild
  • Rename the AddChildInPlace struct to PushChildInPlace

Migration Guide

The struct AddChild has been renamed to PushChild, and the struct AddChildInPlace has been renamed to PushChildInPlace.

@alice-i-cecile alice-i-cecile added C-Usability A simple quality-of-life change that makes Bevy easier to use C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide A-Hierarchy Parent-child entity hierarchies labels Jan 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

alice-i-cecile
alice-i-cecile approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One more suggestion.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 4, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 4, 2024
Merged via the queue into bevyengine:main with commit 93c7e7c Jan 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@sixfold-origami sixfold-origami sixfold-origami approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide C-Usability A simple quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename AddChild to PushChild
3 participants
@garychia @alice-i-cecile @sixfold-origami