Implement TypePath for EntityHash #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
You might want to swap to the strategy in #11182 for all of our reflection assertions in tests at some point.
Not for this PR though.
alice-i-cecile
added
A-ECS
matiqo15
approved these changes
Jan 4, 2024
matiqo15
added
the
S-Ready-For-Final-Review
BD103
added a commit
to BD103/bevy
that referenced
this pull request
Jan 18, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
# Objective - Tests are manually checking whether derived types implement certain traits. (Specifically in `bevy_reflect.) - #11182 introduces [`static_assertions`](https://docs.rs/static_assertions/) to automatically check this. - Simplifies `Reflect` test in #11195. - Closes #11196. ## Solution - Add `static_assertions` and replace current tests. --- I wasn't sure whether to remove the existing test or not. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
ReflectforEntityHashMap#11117 by implementingReflectforEntityHashMapSolution
TypePathforEntityHash, Bevy will automatically implementReflectforEntityHashMapChangelog
TypePathis implemented forEntityHashentity_hashmap_should_impl_reflectwas created to verify that ImplementReflectforEntityHashMap#11117 was solved.