Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fit_canvas_to_parent #11278

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Fix fit_canvas_to_parent #11278

merged 3 commits into from
Mar 3, 2024

Commits on Mar 3, 2024

  1. Follow up to bevyengine#11057 ; fix fit_canvas_to_parent 

    Implemented suggestions from reviewers: a simpler fit_canvas_to_parent
leads to an explicit CSS setting to the canvas.

It has do be set after wgpu creation due to wgpu overriding the canvas width/height:
https://github.com/gfx-rs/wgpu/blob/4400a5847080d1164bdca93a90622414963ed9f3/examples/src/utils.rs#L68-L74
    @Vrixyz
    Vrixyz committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    1c7f49c View commit details
    Browse the repository at this point in the history

  2. use a better query selector, akin to wgpu 

    For reference on wgpu: https://github.com/gfx-rs/wgpu/blob/9f82504d8a3b6e234599b19cc35c299bcec8b138/wgpu-hal/src/gles/web.rs#L117
    @Vrixyz
    Vrixyz committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    3925c22 View commit details
    Browse the repository at this point in the history

  3. use winit window::canvas() function

    @Vrixyz
    Vrixyz committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    106b8d3 View commit details
    Browse the repository at this point in the history