Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Implement minimal reflection probes. (#10057)" #11307

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Revert "Implement minimal reflection probes. (#10057)" #11307

merged 1 commit into from
Jan 12, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 11, 2024 •
edited
Loading

@mockersf mockersf added A-Rendering Drawing game state to the screen O-MacOS Specific to the MacOS (Apple) desktop operating system O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system labels Jan 11, 2024
alice-i-cecile
alice-i-cecile approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think reflection probes are an important feature that we should try to land, but we need to unbreak CI (and not ship bugs).

@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 11, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 11, 2024
@JMS55
Copy link
Contributor

JMS55 commented Jan 11, 2024

Fix for reflection probes should be pretty simple. I believe we just need to add a check if the render device supports the texture binding array feature, rather than a conditional cfg for non wasm platforms.

@mockersf mockersf added this pull request to the merge queue Jan 12, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request Jan 12, 2024
Closed
Merged via the queue into bevyengine:main with commit 3d99663 Jan 12, 2024
32 checks passed
Ixentus pushed a commit to Ixentus/bevy that referenced this pull request Jan 12, 2024
@mockersf @Ixentus
Revert "Implement minimal reflection probes. (bevyengine#10057)" (bev…
f5324f3 
…yengine#11307)

# Objective

- Fix working on macOS, iOS, Android on main 
- Fixes bevyengine#11281 
- Fixes bevyengine#11282 
- Fixes bevyengine#11283 
- Fixes bevyengine#11299

## Solution

- Revert bevyengine#10057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@pcwalton pcwalton Awaiting requested review from pcwalton

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen O-Android Specific to the Android mobile operating system O-iOS Specific to the iOS mobile operating system O-MacOS Specific to the MacOS (Apple) desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.13
4 participants
@mockersf @JMS55 @cart @alice-i-cecile