Cleanup deterministic example #11416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
A-Rendering
rparrett
approved these changes
Jan 18, 2024
| commands.spawn(TextBundle::default()); | ||
| commands.spawn(TextBundle::default().with_style(Style { | ||
| position_type: PositionType::Absolute, | ||
| top: Val::Px(12.0), |
There was a problem hiding this comment.
(no action required) Mildly amused that half of examples that do this use 12px and half use 10px.
There was a problem hiding this comment.
I'll fix that someday... the officially Cart approved margin is 12px: #8478 (comment)
alice-i-cecile
approved these changes
Jan 19, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
deterministiccrashes on CI on Windows because it uses too much memorySolution