Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation in CI: remove lock file #11507

Merged
merged 1 commit into from
Jan 24, 2024
Merged

documentation in CI: remove lock file #11507

merged 1 commit into from
Jan 24, 2024

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jan 24, 2024 •
edited
Loading

Objective

Solution

  • The only issue I could find is the lock file with invalid permissions, try to remove it
  • upload action was doing permissions cleanup in v1, that was removed in v2. we're now using v3

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Jan 24, 2024
@mockersf mockersf mentioned this pull request Jan 24, 2024
Closed
doonv
doonv approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@doonv doonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems kinda cursed (you shouldn't be manually removing lock files), but as a temporary fix for CI, this should work fine.

BD103
BD103 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be merged before #11502. I would rather not downgrade actions once they've been upgraded, and see it as a last resort.

@BD103
Copy link
Member

BD103 commented Jan 24, 2024 •
edited
Loading

An alternative to this is to run chmod -c -R +rX target/doc/.lock, as used in the action before actions/upload-pages-artifact#69. I think both solutions are the same, though rm-ing is a little easier to understand.

@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 24, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 24, 2024
Merged via the queue into bevyengine:main with commit 143066d Jan 24, 2024
25 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@mockersf @tjamaan
documentation in CI: remove lock file (bevyengine#11507)
988c744 
# Objective

- Try to fix deploying docs in CI
- Alternative to bevyengine#11502

## Solution

- The only issue I could find is the lock file with invalid permissions,
try to remove it
- upload action was doing permissions cleanup in v1, that was removed in
v2. we're now using v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doonv doonv doonv approved these changes

@BD103 BD103 BD103 approved these changes

@matiqo15 matiqo15 matiqo15 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mockersf @BD103 @doonv @matiqo15 @alice-i-cecile