Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Animated Material example #11524

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Add Animated Material example #11524

merged 7 commits into from
Jan 26, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 25, 2024 •
edited
Loading

Objective

Solution

  • Add Animated Material example (colors are hue-cycling smoothly per-mesh)

image

Note: this example reproduces the perf issue found in #10610 pretty consistently, with and without the changes from that PR included. Frame time is sometimes around 4.3ms, other times around 12-14ms. Its pretty random per run. I think this clears #10610 for merge.

@atlv24 atlv24 mentioned this pull request Jan 25, 2024
Merged
alice-i-cecile
alice-i-cecile approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a handy learning example, and being able to reproduce the performance problems is a nice bonus.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jan 25, 2024
IceSentry
IceSentry approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not enough instances to reproduce the performance issues on my machine. I need a 10x10 grid to start to see a real effect, but this is a good example either way so I'm fine with it as is.

@atlv24 atlv24 mentioned this pull request Jan 26, 2024
Closed
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 26, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 26, 2024
Merged via the queue into bevyengine:main with commit fb367da Jan 26, 2024
27 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@atlv24 @tjamaan
Add Animated Material example (bevyengine#11524)
16f50c7 
# Objective

- Fixes bevyengine#11516

## Solution

- Add Animated Material example (colors are hue-cycling smoothly
per-mesh)


![image](https://github.com/bevyengine/bevy/assets/11307157/c75b9e66-0019-41b8-85ec-647559c6ba01)

Note: this example reproduces the perf issue found in bevyengine#10610 pretty
consistently, with and without the changes from that PR included. Frame
time is sometimes around 4.3ms, other times around 12-14ms. Its pretty
random per run. I think this clears bevyengine#10610 for merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example or stress test that focuses on animating materials
3 participants
@atlv24 @alice-i-cecile @IceSentry