Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in bevy_reflect #11556

Merged
merged 5 commits into from Jan 27, 2024
Merged

Fix warnings in bevy_reflect #11556

merged 5 commits into from Jan 27, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 27, 2024

Objective

  • Address junk leftover by TypeUuid removal

Solution

  • Get rid of unused deps and imports

@matiqo15 matiqo15 added C-Code-Quality A section of code that is hard to understand or change A-Reflection Runtime information about types labels Jan 27, 2024
alice-i-cecile
alice-i-cecile requested changes Jan 27, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure looks real. I think the weirdness is due to the fact that this is only used in tests. See

bevy/crates/bevy_reflect/src/lib.rs

Line 2058 in 311c0c8

fn vec3_serialization() {

@alice-i-cecile
Copy link
Member

Merging as trivial: CI is doing the heavy lifting here.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 27, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 27, 2024
Merged via the queue into bevyengine:main with commit 886a256 Jan 27, 2024
26 of 27 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@atlv24 @alice-i-cecile @tjamaan
Fix warnings in bevy_reflect (bevyengine#11556)
0544a19 
# Objective

- Address junk leftover by TypeUuid removal

## Solution

- Get rid of unused deps and imports

---------

Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atlv24 @alice-i-cecile @matiqo15