Add a getter for asset watching status on AssetServer
#11578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiqo15
added
A-Assets
matiqo15
reviewed
Jan 28, 2024
Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
mockersf
approved these changes
Jan 28, 2024
matiqo15
approved these changes
Jan 28, 2024
matiqo15
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jan 28, 2024
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
…1578) # Objective - Closes bevyengine#11490. - Allow retrieving the current asset watch behavior from the `AssetServer`. ## Solution - Add the corresponding getter. (also fixes some trailing whitespace). A corresponding helper could also be added on the `AssetPlugin` struct (returning `self.watch_for_changes_override.unwrap_or(cfg!(feature = "watch"))`), but it seems it isn't a current practice to have actual methods on the plugin structs appart from the `Plugin` impl. --- ## Changelog ### Added Added `watching_for_changes` getter on `AssetServer`. --------- Co-authored-by: Mateusz Wachowiak <mateusz_wachowiak@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
AssetServer.Solution
A corresponding helper could also be added on the
AssetPluginstruct (returningself.watch_for_changes_override.unwrap_or(cfg!(feature = "watch"))), but it seems it isn't a current practice to have actual methods on the plugin structs appart from thePluginimpl.Changelog
Added
Added
watching_for_changesgetter onAssetServer.