Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the unsafe_op_in_unsafe_fn lint #11591

Merged
merged 8 commits into from Jan 28, 2024
Merged

Enable the unsafe_op_in_unsafe_fn lint #11591

merged 8 commits into from Jan 28, 2024

Conversation

tguichaoua
Copy link
Contributor

Objective

Solution

  • Enable unsafe_op_in_unsafe_fn at workspace level
  • Fix the lint for most of the crates

@tguichaoua tguichaoua changed the title Unsafe op in unsafe fn Enable the unsafe_op_in_unsafe_fn lint Jan 28, 2024
@tguichaoua tguichaoua mentioned this pull request Jan 28, 2024
Open
3 tasks
alice-i-cecile
alice-i-cecile approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer. These are simple changes: I'd like to tackle the dynamic_plugin and bevy_ecs changes in isolated PRs.

@alice-i-cecile alice-i-cecile added the C-Code-Quality A section of code that is hard to understand or change label Jan 28, 2024
@tguichaoua
Copy link
Contributor Author

tguichaoua commented Jan 28, 2024 •
edited

I'd like to tackle the dynamic_plugin and bevy_ecs changes in isolated PRs.

Yes, as explaned in the associated issue (#11590), for dynamic_plugin, ecs and ptr I leave this work to someone with better knowledge of these crates than me to provide proper safety comments.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 28, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 28, 2024
Merged via the queue into bevyengine:main with commit b0f5d4d Jan 28, 2024
26 of 27 checks passed
@tguichaoua tguichaoua deleted the unsafe_op_in_unsafe_fn branch January 29, 2024 06:09
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@tguichaoua @tjamaan
Enable the unsafe_op_in_unsafe_fn lint (bevyengine#11591)
2544bf5 
# Objective

- Partial fix of bevyengine#11590

## Solution

- Enable `unsafe_op_in_unsafe_fn` at workspace level
- Fix the lint for most of the crates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tguichaoua @james7132 @alice-i-cecile